Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warning in MT6835.cpp #40

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Fix compiler warning in MT6835.cpp #40

merged 2 commits into from
Mar 21, 2024

Conversation

ystradmann
Copy link
Contributor

This change fixes a warning about an implicit overflow of MT6835_REG_CAL_STATUS.

unsigned conversion from 'int' to 'uint8_t' {aka 'unsigned char'} changes value from '275' to '19' [-Werror=overflow]

@runger1101001 runger1101001 changed the base branch from master to dev March 21, 2024 09:33
@runger1101001
Copy link
Member

Thanks for this! I think I have made the same change locally already also :-D

We only take PRs against the "dev" branch of the code, so I changed that. After the tests run I will merge it.

@ystradmann
Copy link
Contributor Author

Perfect, thanks a lot!

@runger1101001 runger1101001 merged commit 232386b into simplefoc:dev Mar 21, 2024
10 checks passed
@runger1101001 runger1101001 added this to the 1.0.7 milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants