Allow one to set up feature checks as well #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The types on the backend are shared for table and feature checks, and have the same API. But, the types are a bit more restrictive for features because they must be able to be computed in a single pass during feature generation, and can't require a new plan. So we don't allow one to _input_ a unique constraint, but we will show it if it's there (it will result in a skipped check if the feature generator runs it). I tried using MaxItems 0 for this, but because go it very weak, it confused 0 with empty and just ignored it. So I instead have it conflict with its base, so you can't input it.
HuwCampbell
force-pushed
the
topic/features-tests
branch
from
7c06922 to
7f34674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.