Improve handling of CSV source fields. #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're hit by [Terraform SDK Issue 258](hashicorp/terraform-plugin-sdk#258) here, which causes the elements of the nested structure to be filled in even if it's not set in the record. This is a very unfortunate part of the SDK. Becase the map contains the empty string unconditionally and we can't use GetOk like we could on the top level, we have to check if the string is empty instead. For boolean fields, we can't even do this properly, as it's always false or true, so our optional elements in the Schema will always be set, fortunately the Spark options will still do the right thing here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're hit by Terraform SDK Issue 258
here, which causes the elements of the nested structure to be
filled in even if it's not set in the record. This is a very
unfortunate part of the SDK.
Becase the map contains the empty string unconditionally and
we can't use GetOk like we could on the top level, we have to
check if the string is empty instead.
For boolean fields, we can't even do this properly, as it's
always false or true, so our optional elements in the Schema
will always be set, fortunately the Spark options will still
do the right thing here.