Support "Operations" in SimPhoNy #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for registering methods as "actions" associated to ontology classes. For example, download and upload commands for files are now implemented in this way. But it would also be possible to write actions that multiply EMMO vectors, retrieve arrays from a URL, convert EMMO units, download a DCAT dataset, ...
kysrpex
added
API details
🌱 new feature
|
@pablo-de-andres @paulzierep @yoavnash This should be useful for integrating ontology and data. There are of course other, more sophisticated approaches such as RDFLib lexicalizers and constructors, or triples fabricated on the fly by the wrappers. I believe it's good to have this also available to be future-proof. I think the fine-details of how a user is supposed to access the actions or whether they should be implemented in a different way are a good topic for a dev meeting. |
|
I like the idea. I wonder if |
|
* Rename "Actions" to "Operations". * Remove the `@action` decorator and use the `_underscore` convention instead to determine which methods should be declared as operations. * Read operations from Python files in ~./simphony_osp/operations (also configurable via the environment variable `SIMPHONY_OPERATIONS_DIR`). * Include the `Operations` abstract class in module `simphony_osp.develop`. * Include the new `find_operations` function in the `simphony_osp.develop`. This function generates entry point declarations for operations automatically.
for more information, see https://pre-commit.ci
|
kysrpex
changed the title
kysrpex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for registering methods as "actions" associated to ontology classes. For example, download and upload commands for files are now implemented in this way (and in fact need to in order to fix #669 cleanly). But it would also be possible to write actions that multiply EMMO vectors, retrieve arrays from a URL, convert EMMO units, download a DCAT dataset, ...
test_files.pyfor an example of how they are used with files (lines 276, 304 are the most relevant).file.pyandsetup.pyfor an example of how a developer implements an action.Note: The PR is not finished because the
Containerclass still needs to be converted to a set of actions too.