Unicode compliant urlencode #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Simon, thanks for making your geocoding library available (and er thanks for Django and all that as well ;-)
I encountered a bug when taking Geonames locations (like "Pnom Pen, Krŏng Phnum Pénh, Cambodia") and then sending them back up through the geocoder using your libraries - the urlencode function used was the Python default one, rather than the Django unicode aware version. So I switched it over and it seems to work nicely.
I have only tested it with the Geonames wrapper so far but I changed all of the scripts because presumably they all work the same way. Let me know if you would like me to be a bit more rigorous about that before accepting the request!
Thanks again,
Brendan.