-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
genus=* for natural=tree, natural=tree_row #266
base: master
Are you sure you want to change the base?
Conversation
Have you seen https://github.com/Heiner-Sch/JOSM-preset-trees-Europe ? IMHO it would be better to improve that (that is add the vespucci translation system and maybe pictures). Naturally making the default preset better is a good idea too. I would suggest using the <list_entry> ... </list_entry> format for the values in the combo in any case, it is much easier to maintain for more complicated tags. The other thing is, people that know something about bio aka not myself, find that adding genus is at best redundant and that you should be using species, any opinion on that? |
@simonpoole : Aw, crap. I did not know https://github.com/Heiner-Sch/JOSM-preset-trees-Europe . My goal was simply to be able to tag the trees that I (as a layman) can recognize, primarily i.e. oaks, maples and birches, and from there it grew a bit further... I think, at the moment I (and a lot of other mappers) would not be able to discern species of the aforementioned genera. However, I think having only Shall we keep this addition to the master preset? Will it interfere with the specialized tree preset? Shall I reduce the number of entries to only keep the ones that laymen are able to recognize? Maybe @Heiner-Sch has an opinion on this too... I wasn't aware of |
There is also a version for Vespucci available: https://github.com/Heiner-Sch/Vespucci-preset-trees-Europe In both presets, for JOSM and Vespucci, you have the possibility to use the unspecified trees. |
Erm, @simonpoole , @Heiner-Sch : How do we proceed? I can either introduce I still think having the genera (only) might be useful for the occasional (layman's) mapping but acknowledge that it has the potential of fragmenting further efforts of refining tree tagging... |
Did you start using the preset? About the genus-only tagging: Yes, it generates effort to complete the trees. My idea was, to built a preset, usable for every level of knowledge, in many situations - from the quick layman to the accurate scientist. I hope to motivate some people to learn more about the trees, if they see that there is more possible, but not obligatory. With this idea in mind, it's maybe not necessary to reduce the number of listed trees. What's your view on this? |
This PR adds a selection of values for key
genus=*
to be used innatural=tree
andnatural=tree_row
.The list of values mostly consists of the top results of https://taginfo.openstreetmap.org/keys/genus#values (minus some non-tree genera), complemented by some further genera (Abies, Cydonia, Pyrus). Having these values should cover approx. 80% of all currently existing usages of
genus=*
in OSM.The english names were taken from Wikipedia, sometimes they describe commonly known species of a genus, not the genus itself, e.g. for Prunus.
Since I'm neither a native English speaker, nor a biologist, this PR will probably contain some errors...