Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Remove deprecated API #484

Merged
merged 1 commit into from
Jan 7, 2025
Merged

API Remove deprecated API #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/DataDifferencer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

use SilverStripe\Assets\Image;
use SilverStripe\Core\Convert;
use SilverStripe\Dev\Deprecation;
use SilverStripe\ORM\DataObject;
use SilverStripe\Model\List\ArrayList;
use SilverStripe\ORM\FieldType\DBField;
Expand Down
12 changes: 1 addition & 11 deletions src/Versioned.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1987,20 +1987,10 @@ public function stagesDifferRecursive(): bool
* @param string $sort
* @param string $limit
* @param string $join Deprecated, use leftJoin($table, $joinClause) instead
* @param string $having @deprecated 2.2.0 The $having parameter does nothing and will be removed without
* equivalent functionality to replace it
* @return ArrayList<Versioned_Version>
*/
public function Versions($filter = "", $sort = "", $limit = "", $join = "", $having = "")
public function Versions($filter = "", $sort = "", $limit = "", $join = "")
{
if ($having) {
Deprecation::withSuppressedNotice(function () {
$message = 'The $having parameter does nothing and will be removed without equivalent'
. ' functionality to replace it';
Deprecation::notice('2.2.0', $message);
});
}

$owner = $this->owner;

// When an object is not yet in the Database, we can't get its versions
Expand Down
Loading