properly encode X-Status #438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Maxime Rainville <[email protected]>
Co-authored-by: Guy Sartorelli <[email protected]>
…ature/stages-differ-recursive NEW: Stages differ recursive
…/deprecate-having API Deprecate Versions() having parameter
…V_BUILD_permission ENH add CAN_DEV_BUILD to non_live_permissions
has_one can now optionally have an array configuration to allow supporting multiple reciprocal has_many in a single has_one relation.
8 tasks
2 tasks
GuySartorelli
requested changes
Feb 19, 2024
Comment on lines
29
to
32
| /** | ||
| * @param bool $unlinked | ||
| * @return ArrayList | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /** | |
| * @param bool $unlinked | |
| * @return ArrayList | |
| */ |
This method is overridden, and inherits its PHPDoc. No need to duplicate it here.
| @@ -42,6 +46,7 @@ public function Breadcrumbs($unlinked = false) | |||
| $this->extend('updateBadge', $badge); | |||
|
|
|||
| if ($badge) { | |||
| /** @var ArrayData $lastItem */ | |||
There was a problem hiding this comment.
Suggested change
| /** @var ArrayData $lastItem */ |
Not needed - we recently added generic typing to lists to handle this
|
Just noticed it's also targetting the wrong branch - please target this PR at |
|
@GuySartorelli i created another pr targeting the right branch turns out it's much easier :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of
silverstripe/silverstripe-admin#1640 (review)
Issues
silverstripe/silverstripe-framework#11105
silverstripe/silverstripe-admin#1639
Pull request checklist