Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH UI updated for versioned objects and all its relations #429

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented Dec 20, 2023

Description

The new doRollback method adds the ability to undo new changes saved to the previous published version.

Parent issue

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a rollback button isn't an AC on silverstripe/silverstripe-admin#1593?

@sabina-talipova
Copy link
Contributor Author

sabina-talipova commented Jan 8, 2024

Adding a rollback button isn't an AC on silverstripe/silverstripe-admin#1593?

How I understood this point of requirements "Cancel draft changes" button state looks up the recursive stage differ. , that we also should add this button for DataObject, since currently we have this option only for SiteTree. Probably, I'm wrong, since there are the mix of requirements for SiteTree and DataObject in ACs. If so I'll close this PR.

@GuySartorelli
Copy link
Member

Closing - we can reference this PR if we decide to go forward with this work in the future, pending the spike.

@GuySartorelli GuySartorelli deleted the pulls/2/versioned-ui branch May 28, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants