API Remove deprecated $join parameters (#486)

silverstripe · Jan 9, 2025 · f985ce7 · f985ce7
1 parent 4ea6402
commit f985ce7
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/Versioned.php b/src/Versioned.php
@@ -1986,7 +1986,6 @@ public function stagesDifferRecursive(): bool
      * @param string $filter
      * @param string $sort
      * @param string $limit
-     * @param string $join Deprecated, use leftJoin($table, $joinClause) instead
      * @return ArrayList<Versioned_Version>
      */
     public function Versions($filter = "", $sort = "", $limit = "", $join = "")
@@ -2002,7 +2001,7 @@ public function Versions($filter = "", $sort = "", $limit = "", $join = "")
         $oldMode = static::get_reading_mode();
         static::set_stage(static::DRAFT);
 
-        $list = DataObject::get(DataObject::getSchema()->baseDataClass($owner), $filter, $sort, $join, $limit);
+        $list = DataObject::get(DataObject::getSchema()->baseDataClass($owner), $filter, $sort, $limit);
 
         $query = $list->dataQuery()->query();
 
@@ -2483,7 +2482,6 @@ public static function prepopulate_versionnumber_cache($class, $stage, $idList =
      * @param string $stage The name of the stage.
      * @param string $filter A filter to be inserted into the WHERE clause.
      * @param string $sort A sort expression to be inserted into the ORDER BY clause.
-     * @param string $join Deprecated, use leftJoin($table, $joinClause) instead
      * @param int $limit A limit on the number of records returned from the database.
      * @param string $containerClass The container class for the result set (default is DataList)
      *
@@ -2494,12 +2492,11 @@ public static function get_by_stage(
         $stage,
         $filter = '',
         $sort = '',
-        $join = '',
         $limit = null,
         $containerClass = DataList::class
     ) {
         ReadingMode::validateStage($stage);
-        $result = DataObject::get($class, $filter, $sort, $join, $limit, $containerClass);
+        $result = DataObject::get($class, $filter, $sort, $limit, $containerClass);
         return $result->setDataQueryParam([
             'Versioned.mode' => 'stage',
             'Versioned.stage' => $stage