Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Add behat tests #1114

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Sep 23, 2021

Issue https://github.com/silverstripeltd/product-issues/issues/473

There's a bug where the email recipients aren't duplicated when a userform is duplicated #1115

This should be fixed the the relevant behat step uncommented before merging this PR

@emteknetnz emteknetnz marked this pull request as draft September 23, 2021 02:11
@emteknetnz emteknetnz force-pushed the pulls/5.10/behat branch 5 times, most recently from 1fcca92 to 5e7f521 Compare September 23, 2021 23:18
@emteknetnz emteknetnz force-pushed the pulls/5.10/behat branch 5 times, most recently from 20e0370 to ba1ee88 Compare September 28, 2021 02:35
@emteknetnz emteknetnz marked this pull request as ready for review September 28, 2021 02:36
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-rainville maxime-rainville merged commit 94fb446 into silverstripe:5 Nov 15, 2021
@maxime-rainville maxime-rainville deleted the pulls/5.10/behat branch November 15, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants