API Remove deprecated API #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
GuySartorelli
force-pushed
the
pulls/4.0/join-param
branch
from
586910e to
2e347a4
Compare
GuySartorelli
commented
Jan 8, 2025
| * @param array $permissionCodes | ||
| * @return DataList<Member> | ||
| */ | ||
| public function getMembersByPermission($permissionCodes = ['ADMIN']) |
There was a problem hiding this comment.
This method was added in 5e9b672 which has no context whatsoever about what its intended use was or how it was intended to work.
Right now it just simply doesn't work. I had a choice between fixing it and removing it, and since there's no context about how it should work and it's impossible for anyone to use right now anyway, fixing it just didn't seem worthwhile.
GuySartorelli
force-pushed
the
pulls/4.0/join-param
branch
from
2e347a4 to
33ab04c
Compare
GuySartorelli
changed the title
GuySartorelli
force-pushed
the
pulls/4.0/join-param
branch
from
33ab04c to
0c9ddb6
Compare
emteknetnz
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue