Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Links to Link(s) to match the rest of the messages #360

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Change Links to Link(s) to match the rest of the messages #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ artifacts/
coverage/
vendor/
.idea/
.vscode
2 changes: 1 addition & 1 deletion client/dist/js/bundle.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions client/lang/en.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ if (typeof(ss) === 'undefined' || typeof(ss.i18n) === 'undefined') {
"LinkField.LINK_MODIFIED_LABEL": "Modified",
"LinkField.LINK_MODIFIED_TITLE": "Link has unpublished changes",
"LinkField.SAVE_RECORD_FIRST": "Cannot add links until the record has been saved",
"LinkField.SAVE_RECORD_FIRST_SINGLE": "Cannot add link until the record has been saved",
"LinkField.SAVE_SUCCESS": "Saved link",
"LinkField.SORT_ERROR": "Unable to sort links",
"LinkField.SORT_SUCCESS": "Updated link sort order"
Expand Down
1 change: 1 addition & 0 deletions client/lang/src/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"LinkField.LINK_MODIFIED_LABEL": "Modified",
"LinkField.LINK_MODIFIED_TITLE": "Link has unpublished changes",
"LinkField.SAVE_RECORD_FIRST": "Cannot add links until the record has been saved",
"LinkField.SAVE_RECORD_FIRST_SINGLE": "Cannot add link until the record has been saved",
"LinkField.SAVE_SUCCESS": "Saved link",
"LinkField.SORT_ERROR": "Unable to sort links",
"LinkField.SORT_SUCCESS": "Updated link sort order"
Expand Down
4 changes: 3 additions & 1 deletion client/src/components/LinkField/LinkField.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,9 @@ const LinkField = ({
const renderPicker = !loadingError && !inHistoryViewer && !saveRecordFirst && (isMulti || linkIDs.length === 0);
const renderModal = !loadingError && !saveRecordFirst && Boolean(editingID);
const loadingErrorText = i18n._t('LinkField.FAILED_TO_LOAD_LINKS', 'Failed to load link(s)');
const saveRecordFirstText = i18n._t('LinkField.SAVE_RECORD_FIRST', 'Cannot add links until the record has been saved');
const saveRecordFirstText = isMulti
? i18n._t('LinkField.SAVE_RECORD_FIRST', 'Cannot add links until the record has been saved')
: i18n._t('LinkField.SAVE_RECORD_FIRST_SINGLE', 'Cannot add link until the record has been saved');
const links = renderLinks();

return <LinkFieldContext.Provider value={{
Expand Down
Loading