Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Remove tabs with only gridfields #247

Merged
merged 1 commit into from
Mar 10, 2024
Merged

FIX Remove tabs with only gridfields #247

merged 1 commit into from
Mar 10, 2024

Conversation

emteknetnz
Copy link
Member

Issue #243

@emteknetnz emteknetnz mentioned this pull request Mar 7, 2024
Closed
GuySartorelli
GuySartorelli requested changes Mar 7, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't remove all gridfields. This is explicitly about removing the gridfield that fluent adds.
If people are adding other gridfields, they should still get hard errors telling them they shouldn't be doing that.

@emteknetnz emteknetnz force-pushed the pulls/4/remove-tabs branch 2 times, most recently from fdc83ad to 74fe725 Compare March 8, 2024 04:55
@emteknetnz
Copy link
Member Author

Updated

@emteknetnz emteknetnz force-pushed the pulls/4/remove-tabs branch from 74fe725 to e40f251 Compare March 10, 2024 22:04
GuySartorelli
GuySartorelli approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well locally, tested with has_one localised link.

@GuySartorelli GuySartorelli merged commit 7ec0c39 into silverstripe:4.0 Mar 10, 2024
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4/remove-tabs branch March 10, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli