Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Throw DatabaseException, not mysqli_sql_exception #11545

Merged
merged 1 commit into from
Jan 13, 2025
Merged

FIX Throw DatabaseException, not mysqli_sql_exception #11545

merged 1 commit into from
Jan 13, 2025
+6 −1

Conversation

GuySartorelli
Copy link
Member

If a unique index is used and that uniqueness is violated, a mysqli_sql_exception is thrown and never caught.
Other mysqli_sql_exceptions that get thrown are caught and converted into DatabaseException.

See #10570

Issue

@GuySartorelli GuySartorelli mentioned this pull request Jan 10, 2025
Open
@emteknetnz emteknetnz merged commit cd1d5de into silverstripe:5.3 Jan 13, 2025
18 checks passed
@emteknetnz emteknetnz deleted the pulls/5.3/wrong-exception branch January 13, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz