Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Apply correct typing to $limit in BasicSearchContext #11535

Merged

Conversation

GuySartorelli
Copy link
Member

Allows for array limits to be used correctly, and updates the expected type to match SearchContext

Issue

Allows for array limits to be used correctly, and updates the expected
type to match SearchContext
@GuySartorelli GuySartorelli marked this pull request as draft January 7, 2025 21:57
@GuySartorelli GuySartorelli marked this pull request as ready for review January 7, 2025 22:11
@emteknetnz emteknetnz merged commit 597d110 into silverstripe:5 Jan 7, 2025
19 checks passed
@emteknetnz emteknetnz deleted the pulls/5/searchcontext-limit branch January 7, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants