API Add strong-typing to SearchContext::getQuery() $limit param #11534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
GuySartorelli
force-pushed
the
pulls/6.0/searchcontext-confusion
branch
from
7a34d0a to
a83de6e
Compare
GuySartorelli
commented
Jan 7, 2025
Comment on lines
-200
to
-202
| if (!($existingQuery instanceof DataList)) { | ||
| throw new InvalidArgumentException("existingQuery must be DataList"); | ||
| } |
There was a problem hiding this comment.
It's strongly typed so this is dead code.
GuySartorelli
force-pushed
the
pulls/6.0/searchcontext-confusion
branch
from
a83de6e to
34e8730
Compare
GuySartorelli
commented
Jan 8, 2025
| * @param array|bool|string $sort Field to sort on. | ||
| * @param array|false|string $sort Field to sort on. |
There was a problem hiding this comment.
true isn't a valid value for $sort so I changed this to explicitly false. Not strong-typing here because the main focus of this PR is the $limit param.
Seems the two search context implementations had different ideas about what was correct for the limit parameter, and the basic one wasn't even handling the values correctly.
GuySartorelli
force-pushed
the
pulls/6.0/searchcontext-confusion
branch
from
34e8730 to
e50188c
Compare
emteknetnz
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems the two search context implementations had different ideas about what was correct for the limit parameter, and the basic one wasn't even handling the values correctly.
Issue