ENH Align ArrayList case sensitivity with other lists #11529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
emteknetnz
requested changes
Jan 7, 2025
| * Whether filter and exclude calls should be case sensitive by default or not. | ||
| * This configuration property is here for backwards compatability. | ||
| * | ||
| * @deprecated 5.1.0 use SearchFilter.default_case_sensitive instead |
There was a problem hiding this comment.
So, is ArrayList going to use SearchFilter.default_case_sensitive ? Quick skim of the diff I cannot see it being referenced, though I may have simply missed it
There was a problem hiding this comment.
ArrayList uses search filters. The search filters do use SearchFilter.default_case_sensitive.
As mentioned in the PR description, ArrayList used to override the searchfilter default. This change removes that override.
emteknetnz
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SearchFilterdefaults to getting its case sensitivity from the database collation settings - this is true even when the list being used isArrayList.ArrayListused to then override that default with its own default, but that was only to preserve BC.This change now aligns the default case sensitivity of
ArrayListwith other lists that useSearchFilterfor their filtering functionality which provides a more consistent and predictable behaviour - callingfilter()on a list which usesSearchFilterwill now always have the same case sensitivity if no modifier is explicitly used.Issue