Merge pull request #1026 from creative-commoners/pulls/4/stop-using-depr

API Stop using deprecated API
silverstripe · Dec 5, 2022 · c143e86 · c143e86
2 parents 1f7a4a5 + 9694a40
commit c143e86
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Models/BaseElement.php b/src/Models/BaseElement.php
@@ -382,7 +382,7 @@ public function getCMSFields()
             if ($styles && count($styles ?? []) > 0) {
                 $styleDropdown = DropdownField::create('Style', _t(__CLASS__.'.STYLE', 'Style variation'), $styles);
 
-                $fields->insertBefore($styleDropdown, 'ExtraClass');
+                $fields->insertBefore('ExtraClass', $styleDropdown);
 
                 $styleDropdown->setEmptyString(_t(__CLASS__.'.CUSTOM_STYLES', 'Select a style..'));
             } else {

diff --git a/src/Search/ElementalSolrIndex.php b/src/Search/ElementalSolrIndex.php
@@ -20,7 +20,9 @@ class ElementalSolrIndex extends SolrIndex
 {
     public function __construct()
     {
-        Deprecation::notice('4.2.0', 'Use a custom index instead', Deprecation::SCOPE_CLASS);
+        Deprecation::withNoReplacement(function () {
+            Deprecation::notice('4.2.0', 'Use a custom index instead', Deprecation::SCOPE_CLASS);
+        });
     }
 
     public function init()