Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Explicity mark nullable parameters for PHP 8.4 #797

Merged
merged 2 commits into from
Dec 2, 2024
Merged

API Explicity mark nullable parameters for PHP 8.4 #797

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a1cd6e
API Explicity mark nullable paramters for PHP 8.4
emteknetnz Nov 28, 2024
9bae522
API Make parameter non-optional for PHP 8.4
emteknetnz Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Model/BlogPostFilter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class BlogPostFilter extends Extension
* @param SQLSelect $query
* @param DataQuery $query
*/
protected function augmentSQL(SQLSelect $query, DataQuery $dataQuery = null)
protected function augmentSQL(SQLSelect $query, ?DataQuery $dataQuery = null)
{

if (Controller::has_curr() && Controller::curr() instanceof LeftAndMain) {
Expand Down Expand Up @@ -60,7 +60,7 @@ protected function augmentSQL(SQLSelect $query, DataQuery $dataQuery = null)
* @param DataQuery $dataQuery
* @param DataObject $dataObject
*/
protected function augmentLoadLazyFields(SQLSelect &$query, DataQuery &$dataQuery = null, $dataObject)
protected function augmentLoadLazyFields(SQLSelect &$query, ?DataQuery &$dataQuery, $dataObject)
{
$blogPostTable = DataObject::getSchema()->tableName(BlogPost::class);
$dataQuery->innerJoin(
Expand Down
Loading