FIX Return null early if there is no file to convert #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the specific problem of not returning null when there is no file to convert with the solution described in #656 (comment)
Note that this is the same solution found in
ImageManupulation::manipulate()which other manipulations such asFill()use.This scenario occurs when trying to convert a file from a
has_onerelation, where there is no record stored in thathas_one, since an empty record is returned instead of null from the magic has one method.Actually changing the logging for other failure scenarios will be handled in silverstripe/silverstripe-framework#11511 in 5.4
Issue
Image::Convert()shows error in frontend instead of returning null #656