FIX Don't log to error handler (#670)

silverstripe · Jan 6, 2025 · c6bbd88 · c6bbd88
1 parent 1a4fffe
commit c6bbd88
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/ImageManipulation.php b/src/ImageManipulation.php
@@ -725,7 +725,7 @@ public function Convert(string $toExtension): ?AssetContainer
             return $converter->convert($this, $toExtension);
         } catch (FileConverterException $e) {
             /** @var LoggerInterface $logger */
-            $logger = Injector::inst()->get(LoggerInterface::class . '.errorhandler');
+            $logger = Injector::inst()->get(LoggerInterface::class);
             $logger->error($e->getMessage());
             return null;
         }

diff --git a/tests/php/ImageManipulationTest.php b/tests/php/ImageManipulationTest.php
@@ -595,7 +595,7 @@ public function testConvert(string $originalFileFixtureClass, string $originalFi
         $mockLogger = $this->getMockBuilder(Logger::class)->setConstructorArgs(['testLogger'])->getMock();
         $mockLogger->expects($success ? $this->never() : $this->once())
             ->method('error');
-        Injector::inst()->registerService($mockLogger, LoggerInterface::class . '.errorhandler');
+        Injector::inst()->registerService($mockLogger, LoggerInterface::class);
 
         $result = $file->Convert($toExtension);