DOC Update error handling and logging docs #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
emteknetnz
requested changes
Jan 6, 2025
en/08_Changelogs/5.4.0.md
Outdated
|
|
||
| Some errors were incorrectly being logged using the error handler service, which resulted in displaying the error in the browser and CLI and, in live mode, not displaying the rest of the response to users. | ||
|
|
||
| This was the result of a misunderstanding about the difference between the `Psr\Log\LoggerInterface.errorhandler` error handler service and the `Psr\Log\LoggerInterface.errorhandler` logging service. |
There was a problem hiding this comment.
Suggested change
| This was the result of a misunderstanding about the difference between the `Psr\Log\LoggerInterface.errorhandler` error handler service and the `Psr\Log\LoggerInterface.errorhandler` logging service. | |
| This was the result of a misunderstanding about the difference between the `Psr\Log\LoggerInterface` error handler service and the `Psr\Log\LoggerInterface.errorhandler` logging service. |
Or the other way around
There was a problem hiding this comment.
Oops yup. Other way around but good catch.
GuySartorelli
force-pushed
the
pulls/5/bad-logging
branch
from
67d6bec to
d59057c
Compare
emteknetnz
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies between the error handler and the logger a little, and adds a note to the changelog about the changes in the related PRs
Issue
LoggerInterface::class . '.errorhandler'halts execution and shows blue screen silverstripe-framework#11511