Skip to content

Commit

Permalink
Merge pull request #355 from creative-commoners/pulls/5.1/clarificati…
Browse files Browse the repository at this point in the history
…on-about-benchmark

DOC Add clarification about benchmark results
  • Loading branch information
Maxime Rainville authored Oct 10, 2023
2 parents 4826b00 + cb16078 commit 1c81fee
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions en/04_Changelogs/5.1.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,14 +141,16 @@ SilverStripe\ORM\DataList:
use_placeholders_for_integer_ids: true
```

The following performance improvements were measured in a test setup where 10,000 record IDs were passed in:
The following performance improvements were measured in a test setup where 10,000 record IDs were passed into a direct call to the methods indicated below:
- DataList::byIDs() - 198% faster - (0.0608s vs 0.1812s)
- RelationList::foreignIDFilter()
- HasManyList::foreignIDFilter() - 108% faster (0.1584s vs 0.3304s)
- ManyManyList::foreignIDFilter() - 108% faster (0.1529s vs 0.3119s)
- ManyManyThroughList::foreignIDFilter() - 27% faster (0.6901s vs 0.8766s)

Note that those observations were made using MySQL.
Please note that this _does not_ mean that your `has_many` relation queries will be 108% faster for example, as those queries do not typically pass a large number of IDs to the `foreignIDFilter()` method.

Note that these observations were made using MySQL.

### Session manager changes {#session-manager}

Expand Down

0 comments on commit 1c81fee

Please sign in to comment.