Skip to content

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Sep 8, 2025

Also reduce id and data-testid clutter.
Also remove some props that were assigned the default value.

Resolves #3800


This change is Reviewable

Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.20%. Comparing base (e082cf9) to head (1e4b973).

Files with missing lines Patch % Lines
src/components/PasswordReset/ResetPage.tsx 0.00% 2 Missing ⚠️
src/components/ProjectSettings/ProjectImport.tsx 0.00% 2 Missing ⚠️
src/components/PasswordReset/Request.tsx 0.00% 1 Missing ⚠️
...oals/CharacterInventory/CharInv/CharacterEntry.tsx 66.66% 1 Missing ⚠️
src/utilities/fontComponents.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3941      +/-   ##
==========================================
- Coverage   74.28%   74.20%   -0.08%     
==========================================
  Files         292      292              
  Lines       10628    10628              
  Branches     1342     1343       +1     
==========================================
- Hits         7895     7887       -8     
- Misses       2352     2359       +7     
- Partials      381      382       +1     
Flag Coverage Δ
backend 85.49% <ø> (ø)
frontend 65.76% <41.66%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec imnasnainaec marked this pull request as ready for review September 11, 2025 20:28
@imnasnainaec imnasnainaec added the 🟩Low Low-priority PR label Sep 11, 2025
@imnasnainaec imnasnainaec changed the title Retire InputLabelProps, InputProps Replace InputLabelProps, InputProps, inputProps with slotProps Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate deprecated props of TextField to slotProps
1 participant