-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix members only stream error & update video metadata #15
Open
HitomaruKonpaku
wants to merge
12
commits into
sigvt:master
Choose a base branch
from
HitomaruKonpaku:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bbc8c9e
Disable assertPlayability to avoid error on members only stream
HitomaruKonpaku 2de2a0a
Parse more video metadata from html
HitomaruKonpaku e5c8b6b
Format & update typing
HitomaruKonpaku e2e969c
Fix milestone message `durationText` parser
HitomaruKonpaku f663e17
Skip error actions
HitomaruKonpaku 0849ac9
Add chat metadata isMembersOnly
HitomaruKonpaku e8d4f5e
Try to fix build issue
HitomaruKonpaku c4182c3
Fix for membersOnly stream
HitomaruKonpaku b902acd
Store video extra metadata
HitomaruKonpaku 66eaa30
Allow to update metadata & extend masterchat
HitomaruKonpaku 0132e74
Fix unreachable code
HitomaruKonpaku 820cf71
Update YTLiveChatPollRenderer payload
HitomaruKonpaku File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you parsed the metadata but I don't think you're exposing it anywhere at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we just return simple data (title/channelId/channelName)
But I just think we can return full metadata in case anyone need 🤔