Skip to content

Conversation

jku
Copy link
Member

@jku jku commented Sep 8, 2025

The main change is the log type change in handleTimestampAPIError() but there's other small tweaks:

  • in the error.go case also avoid the misleading "exiting with error" message and use the original message instead.
  • make sure the two handlers use the same logic to choose between error and warning

This came up in sigstore/rekor-tiles#483

in the error.go case also avoid the misleading "exiting with error"
message and use the original message instead.

Signed-off-by: Jussi Kukkonen <[email protected]>
@jku jku requested a review from a team as a code owner September 8, 2025 07:05
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.32%. Comparing base (6fd19b0) to head (a0b03e6).
⚠️ Report is 471 commits behind head on main.

Files with missing lines Patch % Lines
pkg/api/error.go 0.00% 5 Missing ⚠️
...kg/generated/restapi/configure_timestamp_server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1159       +/-   ##
===========================================
- Coverage   52.85%   17.32%   -35.53%     
===========================================
  Files          20       55       +35     
  Lines        1209     3705     +2496     
===========================================
+ Hits          639      642        +3     
- Misses        509     3010     +2501     
+ Partials       61       53        -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bobcallaway bobcallaway merged commit 6a9f9e6 into sigstore:main Sep 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants