Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor doc update: Clarify client is creating the public private key pair in 'How Sigsto… #359

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

sgpinkus
Copy link
Contributor

…re works' section of overview.

Summary

Was briefly confused about what the responsibilities of Fulcio and the client are and got the stupid idea in head that maybe Fulcio is generating a public/private key pair. But it's just regular x509 CA and CSRs ... The change just adds detail to make that clearer.

Release Note

NONE.

Documentation

This change is documentation. Does not require documentation.

Copy link

netlify bot commented Jan 12, 2025

Deploy Preview for docssigstore ready!

Name Link
🔨 Latest commit aaf4023
🔍 Latest deploy log https://app.netlify.com/sites/docssigstore/deploys/6792c6d21944a60008ab74dd
😎 Deploy Preview https://deploy-preview-359--docssigstore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@haydentherapper
Copy link
Contributor

Can you sign the DCO?

…re works' section of overview.

Signed-off-by: Sam Pinkus <[email protected]>
@sgpinkus
Copy link
Contributor Author

Can you sign the DCO?

Done!

@haydentherapper haydentherapper merged commit 2ba5dc8 into sigstore:main Jan 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants