Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional annotations to secrets #1599

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brkinney
Copy link

@brkinney brkinney commented Jan 9, 2025

Description: Add optional annotations to be passed for secrets.

My team uses a mutating webhook to inject secrets on create. We utilize annotations as part of this webhook which this chart does not currently support.

Testing: This is an optional value, and tested that no examples show any changes when rendering. I also tested rendering with the below test value file to verify my changes show up correctly. I did not think this change warranted a new example to be created.

agent:
  controlPlaneMetrics:
    etcd:
      secret:
        create: true
        annotations:
          testAnnotation: etcdSecret

secret:
  annotations:
    testAnnotation: secret

Documentation: Updated values schema.

Note:
I went with an if conditional in the templates because I saw it was done this way in the serviceAccount.yaml file:
https://github.com/signalfx/splunk-otel-collector-chart/blob/main/helm-charts/splunk-otel-collector/templates/serviceAccount.yaml#L20-L23

Afterwards I noticed that the service.yaml uses with instead:
https://github.com/signalfx/splunk-otel-collector-chart/blob/main/helm-charts/splunk-otel-collector/templates/service.yaml#L17-L20

I don't know if there is a preference but I can change if requested.

@brkinney brkinney requested review from a team as code owners January 9, 2025 21:07
Copy link
Contributor

github-actions bot commented Jan 9, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@brkinney
Copy link
Author

brkinney commented Jan 9, 2025

I have read the CLA Document and I hereby sign the CLA

srv-gh-o11y-gdi-cla added a commit to splunk/cla-agreement that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant