Use simpler string syntax table in Emacs #1587
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This minimally fixes a bug at the cost of slightly worse syntax
highlighting for strings. The bug is that, as written, any of `"`, `'`,
`{`, or `}` are treated as the `|` (generic string delimiter) syntax
class. This means that these act like "string toggles". This has the
benefit of allowing things like string interpolation to work:
"foo{bar}"
^ ^ ^^
| | ||
| | |End string
| | Start string
| End string
Start string
However, this creates problems if the strings are ever unbalanced. E.g.,
the following is mis-highlighted without this patch:
"foo'bar"
^ ^ ^
| | |
| | |
| | Start string
| End string
Start string
Avoid all this by just forcing `'` and `"` to make everything inside them
strings. This loses the syntax highlighting for string interpolation.
However, this seems like a win overall as some internal Wake files run
into this bug and I'm seeing the entire file show up as a string.
Signed-off-by: Schuyler Eldridge <[email protected]>
|
I'm tagging @mikeurbach on this as I know he is an Emacs user and I think has higher elisp proficiency than I do. |
|
Hold off on review/merging this as this has some issues with quote escaping. |
mikeurbach
reviewed
Jun 14, 2024
There was a problem hiding this comment.
Ah, thanks for the tag. I'm honestly not an elisp expert, but happy to take a look. I've been annoyed by this, and I do agree with the premise of this PR. Sacrificing highlighting of interpolated strings in favor of not highlighting the rest of the file as a string if a ' is used in a string seems like a win.
ag-eitilt
reviewed
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minimally fixes a bug at the cost of slightly worse syntax highlighting for strings. The bug is that, as written, any of
",',{, or}are treated as the|(generic string delimiter) syntax class. This means that these act like "string toggles". This has the benefit of allowing things like string interpolation to work:However, this creates problems if the strings are ever unbalanced. E.g., the following is mis-highlighted without this patch:
Avoid all this by just forcing
'and"to make everything inside them strings. This loses the syntax highlighting for string interpolation. However, this seems like a win overall as some internal Wake files run into this bug and I'm seeing the entire file show up as a string.