feat: auto-create metadata.component with default values#66
Open
cdsbarrera wants to merge 5 commits intosiemens:mainfrom
Open
feat: auto-create metadata.component with default values#66cdsbarrera wants to merge 5 commits intosiemens:mainfrom
cdsbarrera wants to merge 5 commits intosiemens:mainfrom
Conversation
hakandilek
reviewed
Feb 6, 2026
| """ | ||
| if self.bom.metadata.component is None: | ||
| self.bom.metadata.component = Component( | ||
| name='Unknown Name', |
Collaborator
There was a problem hiding this comment.
I don't see the benefit of this, on the contrary as this defaults a certain value set, we'll end up with lots of SBOMs for the same Unknown Name@0.0.0 application.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements automatic creation of
metadata.componentwith default values when it's missing from the BOM.Changes
_insert_standard_bom_metadata_component_entry_if_missing()method toStandardBomclassComponentwith default values:name='Unknown Name',version='0.0.0',type=APPLICATIONFixes #65