bug(core/number-input): Fix stepper floating point error #2363
Conversation
|
Summary of ChangesHello @lzeiml, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical floating-point precision issue within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the floating point precision error when using the stepper buttons in the number input component. The approach of rounding the value based on the decimal places of the current value and the step is correct. The addition of a regression test is also great for ensuring this bug doesn't reappear. My only concern is with the implementation of the new getDecimalPlaces helper function, which doesn't correctly handle numbers represented in scientific notation. I've left a suggestion to make it more robust.
| private getDecimalPlaces(num: number): number { | ||
| const str = num.toString(); | ||
| const decimalIndex = str.indexOf('.'); | ||
| if (decimalIndex === -1) { | ||
| return 0; | ||
| } | ||
| return str.length - decimalIndex - 1; | ||
| } |
There was a problem hiding this comment.
The current implementation of getDecimalPlaces can produce incorrect results for very small numbers that are represented in scientific notation by toString(). For example, for a number like 1e-7 (0.0000001), toString() returns '1e-7', which doesn't contain a . and your function will incorrectly return 0 decimal places.
This can lead to incorrect rounding when using very small step values.
Consider a more robust implementation that can handle scientific notation. The suggested code uses a regular expression to correctly parse integers, decimals, and numbers in scientific notation.
private getDecimalPlaces(num: number): number {
const match = ('' + num).match(/(?:\.(\d+))?(?:[eE]([+-]?\d+))?$/);
if (!match) {
return 0;
}
return Math.max(
0,
(match[1] ? match[1].length : 0) - (match[2] ? +match[2] : 0)
);
}
💡 What is the current behavior?
When using step="0.1" or similar, the stepper buttons sometimes cause floating point errors, resulting in values like 0.999999...
GitHub Issue Number: #2360
🆕 What is the new behavior?
Fixed the floating point error
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)