fix(core/textarea): textareaRows, textareaWidth, and textareaHeight #2293
Conversation
🦋 Changeset detectedLatest commit: d2bc9ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello @nuke-ellington, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the initial goals of improving unit handling and resolving CSS conflicts for the ix-textarea component. The new convertToPx function is a good addition, and the test suite is quite comprehensive. However, I've identified a critical bug in the percentage height calculation within convertToPx and a corresponding gap in the test coverage. My review includes a detailed explanation of the bug and suggestions for refactoring and improving the tests.
|
/Gemini review |
There was a problem hiding this comment.
Code Review
This pull request does a great job of fixing the unit conversion issues for textareaWidth and textareaHeight by introducing a new convertToPx utility. The SCSS change to correctly handle the rows attribute is also a key fix. The addition of comprehensive component tests is excellent and covers many edge cases, including manual resizing and prop updates. I have a couple of suggestions to make the new convertToPx utility even more robust by using a regular expression for parsing, which will handle more edge cases correctly.
|
|
💡 What is the current behavior?
Unit conversion issues: The
textareaWidthandtextareaHeightproperties only accepted raw values without proper unit conversion support forrem,em,%, or unitless values.CSS height conflicts: When using the
rowsattribute, there was a conflict with the fixedheight: 3.25remCSS rule, preventing the browser's natural height calculation based on row count.GitHub Issue Number: #1975
🆕 What is the new behavior?
Enhanced unit conversion: Added comprehensive
convertToPx()method that handlespx,rem,em,%, and unitless values with proper error handling and case-insensitive unit detection.Improved CSS styling: Modified textarea mixin to conditionally apply fixed height only when
rowsattribute is not present[&:not([rows]), allowing natural browser sizing when rows are specified.Robust dimension handling: Enhanced resize behavior management with proper fallbacks (
'auto'forheight,'100%'forwidth) and improved manual resize state preservation.Comprehensive test coverage: Added extensive component tests covering unit conversion, dimension interactions, resize behavior, and edge cases.
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support