Skip to content

feature core/input: validation in input components#2278

Open
1307-Dev wants to merge 50 commits intosiemens:mainfrom
1307-Dev:(feature/core)validation-input-components
Open

feature core/input: validation in input components#2278
1307-Dev wants to merge 50 commits intosiemens:mainfrom
1307-Dev:(feature/core)validation-input-components

Conversation

@1307-Dev
Copy link
Collaborator

@1307-Dev 1307-Dev commented Nov 20, 2025

💡 What is the current behavior?

There are some errors which prevent validations from happening has expected.

GitHub Issue Number: #1799
JIRA: IX-2595

🆕 What is the new behavior?

The acceptance criteria for this ticket has been met-
Required input:

Invalid input > Removing value with keyboard > Stays invalid
Invalid input > Remove touched state (e.g. clear button) > Valid again
Invalid input > Programmatically setting it to empty > Stays invalid
Valid input > Removing value with keyboard > It is invalid
Valid input > Remove touched state (e.g. clear button) > Valid
Valid input > Programmatically setting it to empty > It is invalid
Not required input:

Invalid input > Removing value with keyboard > Valid
Invalid input > Remove touched state (e.g. clear button) > Valid again
Invalid input > Programmatically setting it to empty > Valid
Valid input > Removing value with keyboard > Valid
Valid input > Remove touched state (e.g. clear button) > Valid
Valid input > Programmatically setting it to empty > Valid

Furthermore a clear method has been added to all components to remove all validations and inputs added.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📕 Add or update a Storybook story
  • 📄 Documentation was reviewed/updated siemens/ix-docs
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2025

⚠️ No Changeset found

Latest commit: cce01fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@1307-Dev 1307-Dev marked this pull request as ready for review November 21, 2025 07:52
@1307-Dev 1307-Dev marked this pull request as draft November 28, 2025 11:12
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@1307-Dev 1307-Dev marked this pull request as ready for review December 17, 2025 06:20
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before thorough review can be conducted please:

  1. Resolve conflicts
  2. Reduce code duplication (Sonarqube)
  3. Fix pipeline (unit test stage)

@nuke-ellington nuke-ellington added this to the 4.4.0 milestone Jan 26, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2026

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2026

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants