feature core/input: validation in input components#2278
feature core/input: validation in input components#22781307-Dev wants to merge 50 commits intosiemens:mainfrom
Conversation
…ithub.com/1307-Dev/ix into (feature/core)validation-input-components
…ithub.com/1307-Dev/ix into (feature/core)validation-input-components
|
…ithub.com/1307-Dev/ix into (feature/core)validation-input-components
…ithub.com/1307-Dev/ix into (feature/core)validation-input-components
…ithub.com/1307-Dev/ix into (feature/core)validation-input-components
…ithub.com/1307-Dev/ix into (feature/core)validation-input-components
… the classes are present - checkbox.
…m:1307-Dev/ix into (feature/core)validation-input-components
…ithub.com/1307-Dev/ix into (feature/core)validation-input-components
|
nuke-ellington
left a comment
There was a problem hiding this comment.
Before thorough review can be conducted please:
- Resolve conflicts
- Reduce code duplication (Sonarqube)
- Fix pipeline (unit test stage)
…xtend BasePickerInput for shared functionality
…ve type annotations in tests
…m:1307-Dev/ix into (feature/core)validation-input-components
|
|
❌ The last analysis has failed. |





💡 What is the current behavior?
There are some errors which prevent validations from happening has expected.
GitHub Issue Number: #1799
JIRA: IX-2595
🆕 What is the new behavior?
The acceptance criteria for this ticket has been met-
Required input:
Invalid input > Removing value with keyboard > Stays invalid
Invalid input > Remove touched state (e.g. clear button) > Valid again
Invalid input > Programmatically setting it to empty > Stays invalid
Valid input > Removing value with keyboard > It is invalid
Valid input > Remove touched state (e.g. clear button) > Valid
Valid input > Programmatically setting it to empty > It is invalid
Not required input:
Invalid input > Removing value with keyboard > Valid
Invalid input > Remove touched state (e.g. clear button) > Valid again
Invalid input > Programmatically setting it to empty > Valid
Valid input > Removing value with keyboard > Valid
Valid input > Remove touched state (e.g. clear button) > Valid
Valid input > Programmatically setting it to empty > Valid
Furthermore a clear method has been added to all components to remove all validations and inputs added.
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support