Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core/category-filter): remove aria label #1539

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

nuke-ellington
Copy link
Collaborator

💡 What is the current behavior?

GitHub Issue Number: #

🆕 What is the new behavior?

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: 7cc95d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

sonarcloud bot commented Oct 25, 2024

Copy link
Contributor

Report of strict check

src/components/category-filter/category-filter.tsx
  • src/components/category-filter/category-filter.tsx(35,12): error TS2564: Property 'showDropdown' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'showDropdown' has no initializer and is not definitely assigned in the constructor.
  • src/components/category-filter/category-filter.tsx(43,12): error TS2564: Property 'hasFocus' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'hasFocus' has no initializer and is not definitely assigned in the constructor.
  • src/components/category-filter/category-filter.tsx(45,12): error TS2564: Property 'inputValue' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'inputValue' has no initializer and is not definitely assigned in the constructor.
  • src/components/category-filter/category-filter.tsx(46,12): error TS2564: Property 'category' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'category' has no initializer and is not definitely assigned in the constructor.
  • src/components/category-filter/category-filter.tsx(159,12): error TS2531: Object is possibly 'null'.: error TS2531: Object is possibly 'null'.
  • src/components/category-filter/category-filter.tsx(163,20): error TS7006: Parameter 'newValue' implicitly has an 'any' type.: error TS7006: Parameter 'newValue' implicitly has an 'any' type.
  • src/components/category-filter/category-filter.tsx(173,44): error TS2345: Argument of type 'FilterState | undefined' is not assignable to parameter of type 'FilterState'.: error TS2345: Argument of type 'FilterState | undefined' is not assignable to parameter of type 'FilterState'.
  • src/components/category-filter/category-filter.tsx(195,25): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
  • src/components/category-filter/category-filter.tsx(199,12): error TS2531: Object is possibly 'null'.: error TS2531: Object is possibly 'null'.
  • src/components/category-filter/category-filter.tsx(233,5): error TS2531: Object is possibly 'null'.: error TS2531: Object is possibly 'null'.
  • src/components/category-filter/category-filter.tsx(241,5): error TS2531: Object is possibly 'null'.: error TS2531: Object is possibly 'null'.
  • src/components/category-filter/category-filter.tsx(248,14): error TS18047: 'document.activeElement' is possibly 'null'.: error TS18047: 'document.activeElement' is possibly 'null'.
  • src/components/category-filter/category-filter.tsx(252,23): error TS18047: 'document.activeElement' is possibly 'null'.: error TS18047: 'document.activeElement' is possibly 'null'.
  • src/components/category-filter/category-filter.tsx(256,27): error TS2345: Argument of type 'string | null' is not assignable to parameter of type 'string'.: error TS2345: Argument of type 'string | null' is not assignable to parameter of type 'string'.
  • src/components/category-filter/category-filter.tsx(258,13): error TS18047: 'document.activeElement' is possibly 'null'.: error TS18047: 'document.activeElement' is possibly 'null'.
  • src/components/category-filter/category-filter.tsx(260,33): error TS2345: Argument of type 'string | null' is not assignable to parameter of type 'string'.: error TS2345: Argument of type 'string | null' is not assignable to parameter of type 'string'.
  • src/components/category-filter/category-filter.tsx(263,25): error TS2345: Argument of type 'string | null' is not assignable to parameter of type 'string'.: error TS2345: Argument of type 'string | null' is not assignable to parameter of type 'string'.
  • src/components/category-filter/category-filter.tsx(287,21): error TS18047: 'document.activeElement' is possibly 'null'.: error TS18047: 'document.activeElement' is possibly 'null'.
  • src/components/category-filter/category-filter.tsx(294,21): error TS18047: 'document.activeElement' is possibly 'null'.: error TS18047: 'document.activeElement' is possibly 'null'.
  • src/components/category-filter/category-filter.tsx(306,20): error TS2531: Object is possibly 'null'.: error TS2531: Object is possibly 'null'.
  • src/components/category-filter/category-filter.tsx(312,18): error TS2531: Object is possibly 'null'.: error TS2531: Object is possibly 'null'.
  • src/components/category-filter/category-filter.tsx(321,13): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
  • src/components/category-filter/category-filter.tsx(326,11): error TS2322: Type 'undefined' is not assignable to type 'string'.: error TS2322: Type 'undefined' is not assignable to type 'string'.
  • src/components/category-filter/category-filter.tsx(381,5): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
  • src/components/category-filter/category-filter.tsx(386,7): error TS2322: Type 'undefined' is not assignable to type 'string'.: error TS2322: Type 'undefined' is not assignable to type 'string'.
  • src/components/category-filter/category-filter.tsx(391,5): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
  • src/components/category-filter/category-filter.tsx(416,5): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
  • src/components/category-filter/category-filter.tsx(418,5): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
  • src/components/category-filter/category-filter.tsx(427,7): error TS2322: Type 'undefined' is not assignable to type 'string'.: error TS2322: Type 'undefined' is not assignable to type 'string'.
  • src/components/category-filter/category-filter.tsx(501,7): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
  • src/components/category-filter/category-filter.tsx(502,7): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
  • src/components/category-filter/category-filter.tsx(590,12): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
  • src/components/category-filter/category-filter.tsx(592,10): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
  • src/components/category-filter/category-filter.tsx(627,47): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
  • src/components/category-filter/category-filter.tsx(633,22): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
  • src/components/category-filter/category-filter.tsx(641,16): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
  • src/components/category-filter/category-filter.tsx(663,9): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
  • src/components/category-filter/category-filter.tsx(782,13): error TS2322: Type 'string | null' is not assignable to type 'string | undefined'.: error TS2322: Type 'string | null' is not assignable to type 'string | undefined'.

@danielleroux danielleroux merged commit af0af00 into main Oct 25, 2024
15 checks passed
@danielleroux danielleroux deleted the fix/category-filter-aria-label branch October 25, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants