Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms overhaul (including several components) #1318

Open
wants to merge 348 commits into
base: main
Choose a base branch
from

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Jun 11, 2024

💡 What is the current behavior?

GitHub Issue Number: #

🆕 What is the new behavior?

Introduce new validation concept with new components:

  • ix-text-field
  • ix-number-field
  • ix-textarea-field
  • ix-date-field
  • ix-checkbox
  • ix-radio
  • ix-custom-field

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Jun 11, 2024

🦋 Changeset detected

Latest commit: 5820235

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix-angular Minor
@siemens/ix-react Minor
@siemens/ix Minor
@siemens/ix-vue Minor
@siemens/ix-aggrid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 24, 2024

Report of strictNullChecks (strictPropertyInitialization) check

Typescript check

You decreased the total number of errors in PR branch by 45 🎉

New errors in PR branch: src/components/field-label/field-label.tsx - 1 errors
  • src/components/field-label/field-label.tsx:48:11
    • Property 'htmlForClassObserver' has no initializer and is not definitely assigned in the constructor.

ESLint check

You decreased the total number of ESLint warnings in PR branch by 7 🎉

@danielleroux
Copy link
Collaborator Author

/snapshots:approve --args=form-fields.e2e.ts

@danielleroux
Copy link
Collaborator Author

/release:pr

Copy link
Contributor

Please add a changeset via pnpm changeset before attempting a snapshot release.

@danielleroux
Copy link
Collaborator Author

/release:pr

@danielleroux
Copy link
Collaborator Author

/release:pr

Copy link
Contributor

A new release has been made for this PR. You can install it with:

Core library:

npm i @siemens/[email protected]

Angular:

npm i @siemens/[email protected]

React:

npm i @siemens/[email protected]

Vue:

npm i @siemens/[email protected]

jul-lam
jul-lam previously approved these changes Oct 11, 2024
Copy link

sonarcloud bot commented Oct 25, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deploy Preview Deploy a preview instance of the documentation
Projects
None yet
9 participants