Skip to content

Commit

Permalink
Merge remote-tracking branch 'refs/remotes/origin/main' into fix/card…
Browse files Browse the repository at this point in the history
…-colors

# Conflicts:
#	packages/core/src/tests/card-list/card-list.e2e.ts-snapshots/card-list-basic-layout-scrolling-1-chromium---theme-classic-dark-linux.png
#	packages/core/src/tests/card-list/card-list.e2e.ts-snapshots/card-list-basic-layout-scrolling-1-chromium---theme-classic-light-linux.png
#	packages/core/src/tests/card-list/card-list.e2e.ts-snapshots/card-list-basic-should-hide-show-all-button-1-chromium---theme-classic-dark-linux.png
#	packages/core/src/tests/card-list/card-list.e2e.ts-snapshots/card-list-basic-should-hide-show-all-button-1-chromium---theme-classic-light-linux.png
#	packages/core/src/tests/card-list/card-list.e2e.ts-snapshots/card-list-basic-should-not-have-visual-regressions-1-chromium---theme-classic-dark-linux.png
#	packages/core/src/tests/card-list/card-list.e2e.ts-snapshots/card-list-basic-should-not-have-visual-regressions-1-chromium---theme-classic-light-linux.png
#	packages/core/src/tests/card-list/card-list.e2e.ts-snapshots/card-list-basic-should-show-ellipsis-label-1-chromium---theme-classic-dark-linux.png
#	packages/core/src/tests/card-list/card-list.e2e.ts-snapshots/card-list-basic-should-show-ellipsis-label-1-chromium---theme-classic-light-linux.png
  • Loading branch information
matthiashader committed Oct 23, 2024
2 parents f19b993 + ed67657 commit 1371f5e
Show file tree
Hide file tree
Showing 76 changed files with 536 additions and 301 deletions.
5 changes: 5 additions & 0 deletions .changeset/clever-rings-sneeze.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@siemens/ix': patch
---

fix(core/modal): figma - code mismatch
7 changes: 7 additions & 0 deletions .changeset/eight-windows-shout.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@siemens/ix-angular": minor
"@siemens/ix": minor
"@siemens/ix-vue": minor
---

feat(core): improve component a11y
5 changes: 5 additions & 0 deletions .changeset/eighty-clocks-bake.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@siemens/ix': patch
---

fix(core/content-header): adapt spacing
5 changes: 5 additions & 0 deletions .changeset/few-eels-smell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@siemens/ix': patch
---

fix(core/checkbox): page jumps on checkbox click in scrollable ix-content
5 changes: 5 additions & 0 deletions .changeset/nasty-mangos-love.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@siemens/ix': patch
---

fix(core/button): fix keyboard navigation & accessibility
5 changes: 5 additions & 0 deletions .changeset/small-meals-think.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@siemens/ix': patch
---

fix(core/card-list): adapt title margin to figma
4 changes: 2 additions & 2 deletions packages/angular/src/components.ts
Original file line number Diff line number Diff line change
Expand Up @@ -350,14 +350,14 @@ export declare interface IxCardTitle extends Components.IxCardTitle {}


@ProxyCmp({
inputs: ['categories', 'disabled', 'filterState', 'hideIcon', 'i18nPlainText', 'icon', 'labelCategories', 'nonSelectableCategories', 'placeholder', 'readonly', 'repeatCategories', 'staticOperator', 'suggestions']
inputs: ['ariaLabel', 'categories', 'disabled', 'filterState', 'hideIcon', 'i18nPlainText', 'icon', 'labelCategories', 'nonSelectableCategories', 'placeholder', 'readonly', 'repeatCategories', 'staticOperator', 'suggestions']
})
@Component({
selector: 'ix-category-filter',
changeDetection: ChangeDetectionStrategy.OnPush,
template: '<ng-content></ng-content>',
// eslint-disable-next-line @angular-eslint/no-inputs-metadata-property
inputs: ['categories', 'disabled', 'filterState', 'hideIcon', 'i18nPlainText', 'icon', 'labelCategories', 'nonSelectableCategories', 'placeholder', 'readonly', 'repeatCategories', 'staticOperator', 'suggestions'],
inputs: ['ariaLabel', 'categories', 'disabled', 'filterState', 'hideIcon', 'i18nPlainText', 'icon', 'labelCategories', 'nonSelectableCategories', 'placeholder', 'readonly', 'repeatCategories', 'staticOperator', 'suggestions'],
})
export class IxCategoryFilter {
protected el: HTMLElement;
Expand Down
67 changes: 52 additions & 15 deletions packages/core/component-doc.json
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@
"type": "string"
}
],
"optional": false,
"optional": true,
"required": false
},
{
Expand All @@ -604,7 +604,7 @@
"type": "string"
}
],
"optional": false,
"optional": true,
"required": false
},
{
Expand All @@ -625,7 +625,7 @@
"type": "string"
}
],
"optional": false,
"optional": true,
"required": false
},
{
Expand All @@ -651,7 +651,7 @@
"type": "string"
}
],
"optional": false,
"optional": true,
"required": false
}
],
Expand Down Expand Up @@ -1533,7 +1533,13 @@
"styles": [],
"slots": [],
"parts": [],
"listeners": []
"listeners": [
{
"event": "click",
"capture": true,
"passive": false
}
]
},
{
"dirPath": "src/components/card",
Expand Down Expand Up @@ -1936,7 +1942,7 @@
"type": "string"
}
],
"optional": false,
"optional": true,
"required": false
},
{
Expand Down Expand Up @@ -1970,7 +1976,7 @@
"name": "showAllCount",
"type": "number",
"complexType": {
"original": "number | undefined",
"original": "number",
"resolved": "number",
"references": {}
},
Expand All @@ -1984,7 +1990,7 @@
"type": "number"
}
],
"optional": false,
"optional": true,
"required": false
},
{
Expand Down Expand Up @@ -2154,6 +2160,33 @@
]
},
"props": [
{
"name": "ariaLabel",
"type": "string",
"complexType": {
"original": "string",
"resolved": "string",
"references": {}
},
"mutable": false,
"attr": "aria-label",
"reflectToAttr": false,
"docs": "Aria label for the filter input field",
"docsTags": [
{
"name": "since",
"text": "2.6.0"
}
],
"default": "'Filter'",
"values": [
{
"type": "string"
}
],
"optional": false,
"required": false
},
{
"name": "categories",
"type": "{ [id: string]: { label: string; options: string[]; }; }",
Expand Down Expand Up @@ -6302,6 +6335,7 @@
"reflectToAttr": false,
"docs": "Display a chevron icon in list items. Defaults to 'false'",
"docsTags": [],
"default": "false",
"values": [
{
"type": "boolean"
Expand Down Expand Up @@ -6399,6 +6433,7 @@
"reflectToAttr": false,
"docs": "Show chevron on right side of the event list item",
"docsTags": [],
"default": "false",
"values": [
{
"type": "boolean"
Expand Down Expand Up @@ -6435,7 +6470,7 @@
"type": "string"
}
],
"optional": false,
"optional": true,
"required": false
},
{
Expand All @@ -6451,6 +6486,7 @@
"reflectToAttr": false,
"docs": "Disable event list item",
"docsTags": [],
"default": "false",
"values": [
{
"type": "boolean"
Expand Down Expand Up @@ -6482,7 +6518,7 @@
"type": "string"
}
],
"optional": false,
"optional": true,
"required": false
},
{
Expand All @@ -6498,6 +6534,7 @@
"reflectToAttr": false,
"docs": "Show event list item as selected",
"docsTags": [],
"default": "false",
"values": [
{
"type": "boolean"
Expand Down Expand Up @@ -9281,7 +9318,7 @@
"type": "string"
}
],
"optional": false,
"optional": true,
"required": false
},
{
Expand Down Expand Up @@ -11736,7 +11773,7 @@
"type": "string"
}
],
"optional": false,
"optional": true,
"required": false
},
{
Expand All @@ -11757,7 +11794,7 @@
"type": "string"
}
],
"optional": false,
"optional": true,
"required": false
}
],
Expand Down Expand Up @@ -12186,7 +12223,7 @@
"type": "string"
}
],
"optional": false,
"optional": true,
"required": false
},
{
Expand Down Expand Up @@ -12229,7 +12266,7 @@
"type": "string"
}
],
"optional": false,
"optional": true,
"required": false
},
{
Expand Down
15 changes: 4 additions & 11 deletions packages/core/scss/components/_checkboxes.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,11 @@
/* Base for label styling */
[type='checkbox']:not(:checked),
[type='checkbox']:checked {
clip: rect(0 0 0 0);
clip-path: inset(50%);
height: 1px;
width: 1px;
max-height: 1px;
max-width: 1px;
min-height: 0px;
min-width: 0px;
overflow: hidden;
position: absolute;
white-space: nowrap;
appearance: none;
opacity: 0;
cursor: pointer;
height: 0;
width: 0;
}

[type='checkbox']:not(:checked) + label,
Expand Down
Loading

0 comments on commit 1371f5e

Please sign in to comment.