-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lb/new clean #65
base: main
Are you sure you want to change the base?
Lb/new clean #65
Conversation
Please upon review let me know how to handle the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me everything looks fine, thank you!
Let's wait with the merge until we also have a review by @susuhahnml.
I propose to keep all the information in the file, but move the outdated parts to a new section in the bottom, in which we also state that these features are only available in an old version. |
Certainly! Should I make the proposed changes and send you a version for review directly, or would it be better to keep the review process for this file on github? |
Let's do it here on GitHub |
Sorry for the delay, Susana and I were on LPNMR and ICLP last week. The changes look good, thank you! |
I have reorganised the |
This is the new "minimal" cleaned version of the code.
Here is the list of changes:
racks
example constraints into two different files. One has the attribute-oriented constraints, the other the object-oriented constraints. (The attribute ones do not seem to significantly affect performance so they are included in the encodings.)ooasp_simple.lp
toooasp.lp
since this is the new current main encoding.requirements.txt
accordinglyREADME.md
to include information about installing using therequirements.txt
for the users who would like to avoid using poetry.print
statement, which was ruining theapp.py
output formatting.#show
statements as proposed in teams in order to make the output easier to work with and reusable.