Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yulia's first documentation article #239

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Yulia's first documentation article #239

wants to merge 3 commits into from

Conversation

YLukashina
Copy link

Hands-On Tutorial

brokad
brokad reviewed Nov 1, 2021
View reviewed changes
Copy link
Contributor

@brokad brokad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @YLukashina! A few quick comments 😄

docs/docs/tutorials/creating-fake-user-data.md Outdated Show resolved Hide resolved
docs/docs/tutorials/creating-fake-user-data.md Outdated Show resolved Hide resolved
docs/docs/tutorials/creating-fake-user-data.md Outdated Show resolved Hide resolved
@brokad
Copy link
Contributor

brokad commented Nov 1, 2021

Just in case this is helpful: you can run a local copy of the documentation (to preview the output in a browser) with

cd docs/ ; npm install && npm run start

@YLukashina YLukashina requested a review from brokad November 2, 2021 11:35
@YLukashina YLukashina marked this pull request as draft November 2, 2021 11:40
@YLukashina YLukashina marked this pull request as ready for review November 2, 2021 17:19
@YLukashina
Copy link
Author

Hi guys, I have some problems with installing docusaurus but I addressed all the comments. Feel free to review it again. Thank you.

iamwacko
iamwacko approved these changes Oct 23, 2022
View reviewed changes
Copy link
Collaborator

@iamwacko iamwacko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Is there anything else you want to add, or do you want me to merge it now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamwacko iamwacko iamwacko approved these changes

@brokad brokad Awaiting requested review from brokad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YLukashina @brokad @iamwacko