Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow project restart #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

lasantosr
Copy link

@lasantosr lasantosr commented Jan 30, 2024

When upgrading shuttle version, a restart is required according to the docs:
https://docs.shuttle.rs/configuration/shuttle-versions#upgrading-shuttle-version

This PR allows the action to restart the project before the deployment

@jonaro00
Copy link
Member

jonaro00 commented Feb 2, 2024

Thanks for the suggestion!

I think this is a good enough solution for those that want it, but restarting the project at each deployment can become very chaotic (especially if pushing commits rapidly), which is why we still recommend a manual restart when you want to upgrade the shuttle version.
I don't think having this as an official option is suitable, since we are planning to remove the need of restarting the project altogether (and each deployment gets its own up to date container).
So, I think we can leave this open for visibility, and let anyone who wants to use it do so.

P.S. You could also consider supporting the idle minutes flag.

@lasantosr
Copy link
Author

I think this is a good enough solution for those that want it, but restarting the project at each deployment can become very chaotic (especially if pushing commits rapidly), which is why we still recommend a manual restart when you want to upgrade the shuttle version.

Having it as a variable allows the job to enable or disable it based on user input or other conditions.

If you're planning to remove the need of restarting the project, then I can understand why it's not being merged, thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants