Skip to content

Conversation

jannikluhn
Copy link
Contributor

The registry is intentionally basic. It allows only the owner to register triggers, but without any restrictions. The contract is upgradable so that we can open it up, add restrictions (such as for TTL or contract addresses), and add additional features such as pricing.

There are additional helper contracts and scripts that facilitate testing beyond foundry's tests (such as manual end-to-end tests and rolling shutter's automated tests).

Copy link
Contributor

@blockchainluffy blockchainluffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just one small question

The new version allows explicitly specifying both contract paths and
names instead of inferring one from the other. This was necessary
because the event trigger registry has a slightly different path due to
the version suffix.

Also, we now pass the contract bytecode to abigen.
@jannikluhn jannikluhn force-pushed the event-trigger-registry branch from 20b96d6 to 8b0051b Compare September 8, 2025 10:48
@jannikluhn jannikluhn merged commit 7e53b15 into main Sep 8, 2025
2 checks passed
@ylembachar ylembachar linked an issue Sep 22, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement contract logic
2 participants