Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Scarb references to latest v2.8.1 #217

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Conversation

stranger80
Copy link
Contributor

This is a naive attempt to fix #216 - as without these Starklings refuse to compile.

@enitrat
Copy link
Collaborator

enitrat commented Sep 5, 2024

@stranger80 thank you for updating starklings 🙏 can you update rust in CI to 1.80.0 ?

@stranger80
Copy link
Contributor Author

Rust updated to 1.80.0 in workflow definition.

@shramee
Copy link
Owner

shramee commented Sep 5, 2024

Build seems to be failing does it work when building/running locally?

@enitrat
Copy link
Collaborator

enitrat commented Sep 5, 2024

hm apparently 1.80.0 fials as well
i tried with 1.82.0-nightly and it works

@stranger80
Copy link
Contributor Author

It works for me with 1.80.1 - shall we use that?

@enitrat
Copy link
Collaborator

enitrat commented Sep 5, 2024

yes we can

@shramee
Copy link
Owner

shramee commented Sep 5, 2024

I'll leave this to you @enitrat

@stranger80
Copy link
Contributor Author

stranger80 commented Sep 5, 2024

OK, one more step was missing - force update the dependencies (cargo update) - this is required to get to the latest crate versions.

@enitrat enitrat merged commit 2c3db2a into shramee:main Sep 5, 2024
@shramee
Copy link
Owner

shramee commented Sep 5, 2024

@enitrat This PR seems to have removed the build step in ci...
image

@enitrat
Copy link
Collaborator

enitrat commented Sep 5, 2024

Ah oops I didn't see the last commit 🤦

@shramee
Copy link
Owner

shramee commented Sep 5, 2024

Aah actually, looks like CI is broken...

@shramee
Copy link
Owner

shramee commented Sep 5, 2024

Addressed in #220

@shramee
Copy link
Owner

shramee commented Sep 5, 2024

@enitrat We might have to undo this one, because we need Cairo v2.8 compatibility... Even after updating versions on runner crates... I'm getting this error...

image

So tests don't work. Probably some changes in Serde with the new Scarb version...

@enitrat
Copy link
Collaborator

enitrat commented Sep 5, 2024

ah ok yes sorry 🙏 did this on mobile, let's revert

@shramee
Copy link
Owner

shramee commented Sep 5, 2024

No worries, because of the broken CI file, the tests weren't run... So there weren't any errors on the PR.

@enitrat
Copy link
Collaborator

enitrat commented Sep 5, 2024

We can just add cfg(test) attribute on test modules I think

@shramee
Copy link
Owner

shramee commented Sep 5, 2024

Didn't quite work...

It does work via scarb in the runner crate though... But not via Starklings.

@shramee
Copy link
Owner

shramee commented Sep 5, 2024

Fixed serde...
#221 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to compile Starklings for any combination of Rustc, Scarb, Cairo lang versions
3 participants