-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Scarb references to latest v2.8.1 #217
Conversation
@stranger80 thank you for updating starklings 🙏 can you update rust in CI to 1.80.0 ? |
Rust updated to 1.80.0 in workflow definition. |
Build seems to be failing does it work when building/running locally? |
hm apparently 1.80.0 fials as well |
It works for me with 1.80.1 - shall we use that? |
yes we can |
I'll leave this to you @enitrat |
OK, one more step was missing - force update the dependencies ( |
@enitrat This PR seems to have removed the build step in ci... |
Ah oops I didn't see the last commit 🤦 |
Aah actually, looks like CI is broken... |
Addressed in #220 |
@enitrat We might have to undo this one, because we need Cairo v2.8 compatibility... Even after updating versions on runner crates... I'm getting this error... So tests don't work. Probably some changes in Serde with the new Scarb version... |
ah ok yes sorry 🙏 did this on mobile, let's revert |
No worries, because of the broken CI file, the tests weren't run... So there weren't any errors on the PR. |
We can just add cfg(test) attribute on test modules I think |
Didn't quite work... It does work via scarb in the runner crate though... But not via Starklings. |
Fixed serde... |
This is a naive attempt to fix #216 - as without these Starklings refuse to compile.