Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add the first starknet components exercise #207

Closed
wants to merge 2 commits into from
Closed

feat: add the first starknet components exercise #207

wants to merge 2 commits into from

Conversation

raghav-rama
Copy link
Contributor

@raghav-rama raghav-rama commented Apr 7, 2024 •
edited
Loading

Pull Request Description:

Issue Fixed:

Changes Made:

  • Added the initial basic exercise.
  • More exercises yet to be incorporated.

Additional Details:

  • Work in Progress: Still refining and enhancing the content.
  • Focus: Primarily focusing on adding exercises.
  • Status: Work ongoing; further updates imminent.

@raghav-rama raghav-rama marked this pull request as draft April 7, 2024 22:01
shramee
shramee requested changes Apr 7, 2024
View reviewed changes
Copy link
Owner

@shramee shramee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🙌
Just a few tiny tweaks.

exercises/starknet/components/starknet6.cairo Show resolved Hide resolved
exercises/starknet/components/starknet6.cairo Outdated Show resolved Hide resolved
exercises/starknet/components/starknet6.cairo Outdated Show resolved Hide resolved
info.toml Outdated Show resolved Hide resolved
@shramee shramee self-assigned this May 1, 2024
@shramee shramee marked this pull request as ready for review May 1, 2024 12:28
shramee added a commit that referenced this pull request May 2, 2024
@shramee @raghav-rama
starknet components exercise (#209, #207)
5927a8b 
* feat: add the first starknet components exercise
* chore: improve comments

---------

Co-authored-by: raghav-rama <[email protected]>
@shramee
Copy link
Owner

shramee commented May 2, 2024

Closing in favor of #209 which is rebased with master to have the tests pass.

Thanks @raghav-rama!!

@shramee shramee closed this May 2, 2024
@shramee shramee mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shramee shramee shramee requested changes

Assignees

@shramee shramee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add starknet components exercise
2 participants
@raghav-rama @shramee