feat(stylelint-plugin-meteor): auto-fix rem spacing values #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Lucsy3012
reviewed
Jan 23, 2025
Lucsy3012
approved these changes
Jan 23, 2025
@shopware-ag/meteor-admin-sdk
@shopware-ag/stylelint-plugin-meteor
@shopware-ag/meteor-component-library
@shopware-ag/meteor-tokens
@shopware-ag/meteor-icon-kit
commit: |
alastair-simon
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I added a auto-fixer for rem spacing values.
Why?
This makes it easier to migrate a large amount of spacing over to the spacing tokens.
How?
The fixer multiplies the rem value by 16, checks if the value is on the scale. If it is then it replaces that with a spacing token. If not it just reports that line.
Testing?
I've added some tests to make sure the rule works as expected.