feat: add new address #300
Open
+115
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanpham-sw
force-pushed
the
next-40295/country-not-eligible-delivery-ats
branch
from
78537bd to
87304c6
Compare
vanpham-sw
commented
Feb 4, 2025
src/services/TestDataService.ts
Outdated
| @@ -100,7 +100,7 @@ export class TestDataService { | |||
| * | |||
| * @private | |||
| */ | |||
| private highPriorityEntities = ['order', 'product', 'landing_page', 'shipping_method', 'sales_channel_domain', 'sales_channel_currency', 'sales_channel_country', 'customer']; | |||
| private highPriorityEntities = ['order', 'product', 'landing_page', 'shipping_method', 'sales_channel_domain', 'sales_channel_currency', 'sales_channel_country', 'customer', 'customer_address']; | |||
There was a problem hiding this comment.
I'm having an issue cleaning up country data in after hook(409 conflict error), despite having added customer_address here.
There was a problem hiding this comment.
Somehow the address data is still in use when you try to delete it.
frobel
requested changes
Feb 4, 2025
| const task = (address: Address) => { | ||
| return async function AddNewAddress() { | ||
|
|
||
| await ShopCustomer.goesTo(StorefrontAccountAddresses.url()); |
There was a problem hiding this comment.
I would put that line (goesTo) into the test so that It is more transparent where you create the address.
There was a problem hiding this comment.
and we save execution time because the fixture ShopCustomer is large and takes much more time to generate compared to a simple page object.
vanpham-sw
force-pushed
the
next-40295/country-not-eligible-delivery-ats
branch
from
66f07a3 to
4688f07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform PR: shopware/shopware#6589