delete print_warning

shogun-toolbox · Jun 24, 2020 · 11f8db6 · 11f8db6
1 parent 145f093
commit 11f8db6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/src/shogun/labels/BinaryLabelEncoder.h b/src/shogun/labels/BinaryLabelEncoder.h
@@ -33,7 +33,7 @@ namespace shogun
 		{
 			const auto result_vector = labs->as<DenseLabels>()->get_labels();
 			check_is_valid(result_vector);
-			if (print_warning && !can_convert_float_to_int(result_vector))
+			if (!can_convert_float_to_int(result_vector))
 			{
 				io::warn(
 				    "({}, {}) have been converted to (-1, 1).",

diff --git a/src/shogun/labels/LabelEncoder.h b/src/shogun/labels/LabelEncoder.h
@@ -59,9 +59,6 @@ namespace shogun
 			return "LabelEncoder";
 		}
 
-		void set_print_warning(bool print_warning){
-			print_warning = print_warning;
-		}
 	protected:
 		SGVector<float64_t> fit_impl(const SGVector<float64_t>& origin_vector)
 		{
@@ -116,7 +113,6 @@ namespace shogun
 			    });
 		}
 
-		bool print_warning = true;
 		std::set<float64_t> unique_labels;
 		std::unordered_map<float64_t, float64_t> normalized_to_origin;
 	};

diff --git a/src/shogun/labels/MulticlassLabelsEncoder.h b/src/shogun/labels/MulticlassLabelsEncoder.h
@@ -32,11 +32,11 @@ namespace shogun
 		SGVector<float64_t> fit(const std::shared_ptr<Labels>& labs) override
 		{
 			const auto result_vector = labs->as<DenseLabels>()->get_labels();
-			if (print_warning && !can_convert_float_to_int(result_vector))
+			if (!can_convert_float_to_int(result_vector))
 			{	
 				std::set<float64_t> s(result_vector.begin(), result_vector.end());
 				io::warn(
-				    "{} have been converted to 0...{}", 
+				    "({}) have been converted to (0...{})", 
 						fmt::join(s, ", "),
 							 result_vector.vlen - 1);
 			}