Video export cleanup #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Stuart Axon <stuaxo@users.noreply.github.com>
stuaxo
reviewed
May 28, 2021
stuaxo
reviewed
Jun 2, 2021
| default:"~/.virtualenvs/shoebot/", | ||
| description: `Path where Shoebot was installed`, | ||
| default:"/usr/local/", | ||
| description: `Path where Shoebot was installed. If you installed Shoebot system-wide, this should be "/usr/local/". If you installed it with virtualenvwrapper, it's "~/virtualenvs/shoebot".`, |
There was a problem hiding this comment.
~/.local/ might be good - it's the default if you install with pip --user (and I think --user is the default).
trying to untangle dependencies installed via pip (like Pillow) from the users system installed ones isn't much fun.
stuaxo
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from the comments on #4, plus a clarification on 10-second video exports