Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5 - Save volume of the mpv player #12

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Hibbins
Copy link

@Hibbins Hibbins commented Oct 26, 2024

Closes #5

📑 Description

I added the following:

  • Default configuration file, that can keep options, such as volume etc.
  • Lua script that gets the volume from mpv and saves it to the configuration file
  • Made sure the Lua script is being run together with mpv, using the --script flag
  • Added function that gets the volume value from the configuration file whenever the play function is called

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Copy link

netlify bot commented Oct 26, 2024

Deploy Preview for terminal-radio ready!

Name Link
🔨 Latest commit 16583df
🔍 Latest deploy log https://app.netlify.com/sites/terminal-radio/deploys/671d1805186e6100081bb095
😎 Deploy Preview https://deploy-preview-12--terminal-radio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Hibbins
Copy link
Author

Hibbins commented Oct 26, 2024

Please let me know what you think of the proposed solution! 🙂 @shinokada

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Remember volume
1 participant