Various improvements (01) #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes disassembling of fixed-width integer data. Namely it fixes wrong disassembly on Pharo caused by `printStringRadix: 16` which - on Pharo - adds prefix `16r`. This was not caught by test because the test used the same method construct the expected value. Second, if fixes disassembly w.r.t. symbolic values.
This commit extends `AcProcessorDescription class >> #decode:` to support decoding of multiple instructions from an byte array (for now only for fixed-width instructions). This is useful to decode a chunk of binary code at once.
This commit adds `#isAcAsmOperandModifier` in order to replace `#isKindOf:`.
This commit caches encoding bitvector in ProcessorInstructionDeclaration instead of creating it on demand. This change speeds up decoding of ~170 instructions from ~35secs to ~15 secs (which is still appalling).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains bunch of changes in ArchC core that accumulated while working on relocations but that are not specific to relocations.