Overhaul Z3-level Datatype API #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Z3 C API to Datatypes, is rather cumbersome and unpleasant to program to. The Z3 Python API attempts to improve this using Python's "dynamic" features, synthesizing dynamic attributes for constructors, recognizers and projections. Our Smalltalk API so far was inspired by the Python API; the result was somewhat awkward. PR 338 proposes one approach to improve on that. This commit takes a different approach. Instead of trying to sweeten the pill, we stay 100% faithful to Nikolaj's C API. For higher-level use we jump up to Fixpoint's DataDecl; the latter mirrors the Haskell API. We skip the "mid-level" compromises altogether.
shingarov
force-pushed
the
z3-datatype-api
branch
from
9ec79d3 to
8fe5c6c
Compare
Earlier commit
Replace Z3Datatype pythonism in favor of Fixpoint-level API
introduced test `Z3DatatypeTest >> testUniqueVoidNeg2` which was
crashing on Smalltalk/X but not Pharo. It turned out that the problem
was that `sort_refs` passed down to `Z3_mk_constructor` was an empty
array while the Z3 API assumes (requires) that it is of the same size
as `sorts` array.
The reason why this was crashing on Smalltalk/X and not on Pharo is
a subtle difference in `externalU32ArrayFrom:` (and externalArrayFrom:`)
- on Smalltalk/X this returns `null` pointer if the (smalltalk) array
is empty whereas on Pharo it returned valid pointer.
This commit fixes the test and adds an assert in
`mkConstructor:recognizer:fields:referencing:` to avoid a hard crash
should anyone pass `sorts` and `sort_refs` of different sizes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.